Skip to content

fix(useEventSource): replace wrong Data generic with string #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(useEventSource): replace wrong Data generic with string #4974

wants to merge 1 commit into from

Conversation

Menci
Copy link

@Menci Menci commented Aug 19, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Remove the Data generic from useEventSource and just use string instead, as SSE's data could only be string.

https://html.spec.whatwg.org/multipage/server-sent-events.html#the-eventsource-interface

Additional context

In the original PR, the author referenced MDN's docs:

The data sent by the message emitter; this can be any data type, depending on what originated this event

Yes, this applies to MessageEvent, because that MessageEvent is not only born for EventSource, but also used in non-SSE scenarios like postMessage. This is possible to be other types in other scenarios, but only string is possible for SSE.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 19, 2025
@OrbisK
Copy link
Collaborator

OrbisK commented Aug 20, 2025

I think this is obsolete with #4953

@Menci can you confirm this?

@Menci
Copy link
Author

Menci commented Aug 20, 2025

@OrbisK Oh, that makes sense!

@OrbisK
Copy link
Collaborator

OrbisK commented Aug 20, 2025

Thank you anyway ❤️

@OrbisK OrbisK closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Menci @OrbisK