Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lang clarification to translatable attributes section. #1690

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Feb 3, 2022

Resolves #1365


Preview | Diff

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@cookiecrook cookiecrook added this to the ARIA 1.3 milestone Feb 3, 2022
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as-is, but might be a bit clearer if we insert the word "attribute" before "value".

Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. 👍

@pkra pkra self-assigned this Mar 8, 2022
@pkra pkra merged commit e138d5c into main Apr 15, 2022
@pkra pkra deleted the issue-1365 branch April 15, 2022 16:28
github-actions bot added a commit that referenced this pull request Apr 15, 2022
SHA: e138d5c
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
* add lang clarification to translatable attributes section.
Resolves #1365
* Removing accidental whitespace line break
* editorial nit
* carmacleod suggestion: 'value' -> 'attribute value'
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
* Change references
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute with natural language but no language metadata
5 participants