-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog in guidelines/index.html #4123
Conversation
Updated changelog to only record changes made that were preserved through WCAG 2.2's Oct 2023 publication.
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Added a list of the errata changes to the change log. If these are considered too granular for the change log, they could be moved to the errata page instead.
removed the word "substantive" since some of the things listed are editorial
small editorial fixes
quotation marks align with other styling
@kfranqueiro the anchor links to the definitions are not showing up in the preview (circa line 300). I'm assuming they will when published? |
@alastc I've added this to the Errata for CFC column, just to make sure it is not overlooked. This is deviating from our process and is not even necessary, since this update to an appendix of the spec does not need to be part of the CFC process, but I thought it made sense to include in this process.. It has not been reviewed by anyone at this point. |
I'm not sure what you're referring to near line 300 which is just Meanwhile, separate question: I see this is removing content from the change log section; is that all stuff that specifically happened between initial drafts of 2.2 and its final publication? |
Yes, thanks for the other preview.
Technically, EVERYTHING that remains in the change log from the original publication is stuff that happened between its initial drafts and final publication, but I have retained a single mention of each new SC that was added, along with any other adopted changes that were made in the spec after 2.1. I have also modified the preamble to try to make this clearer. |
slight rewording to clarify what is in the change log
not a definition, so adding relative link
not a definition, so adding relative link
This effectively replaces what the pr-preview bot currently does (and what #2220 sought to do within the repo). The problem with the pr-preview bot is its previews don't fully work (e.g. as seen in #4123). ## Changes - Remove `.pr-preview.json` to stop pr-preview bot from running - Add logic to `eleventy.config.ts` to copy `guidelines` folder assets and run through spec-generator (the same thing we use for GH Pages builds; also the same thing used by the pr-preview bot, IIUC) when running a standard build through netlify - Conditionally add guidelines list item to top-level `index.html` (which is only used for local dev and PR builds) - Tangentially, rename our github-pages push workflow to be more distinguishable in the Actions tab
Removed "updated" since that PR did not pass CFC
Updated changelog to only record changes made that were preserved through WCAG 2.2's Oct 2023 publication.
Added normative errata to the change log incorporated into the republication
NOTE @iadawn, I took a guess on the actual republication date of Nov 15, which will need to be updated to match the real date.
Preview | Diff