This repository was archived by the owner on Jun 3, 2021. It is now read-only.
Support SSL verification via internal CA bundle #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbiddle
approved these changes
Jul 28, 2017
gitlab/config.py
Outdated
| except Exception: | ||
| pass | ||
| try: | ||
| self.ssl_verify = self._config.getboolean(self.gitlab_id, | ||
| 'ssl_verify') | ||
| except ValueError: | ||
| self.ssl_verify = self._config.get(self.gitlab_id, 'ssl_verify') |
There was a problem hiding this comment.
I think it's worth adding an explanation comment here as well, just in case someone is following a stack trace they may not see the one above.
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
7fda486 to
c10a4dc
Compare
|
Okay, cool. Submitted a PR to the original fork: python-gitlab#294 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is purely a review request, not a merge. When I get a ship it, I can create a new PR direct from my branch to the original master branch