Copy link to clipboard & WebShare API support #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy to clipboard is not supported on IE, see https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share#browser_compatibility
WebShare API is only partially supported, see https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share#browser_compatibility
hidden = true didn't always work on Chrome macOS
wcoder
approved these changes
Nov 16, 2021
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for copying the link to the clipboard. IFAIK only IE doesn't support this, see browser compatibility for more information. If the feature is not supported on the browser, the "copy" buttons should automatically hide.
I also added support for WebShare API but it's only partially supported depending on the OS and browser, see browser compatibility for more information. If the feature is not supported on the browser, the "share to..." buttons should automatically hide.
Issues: #10
In a way, #21 is supported if you are on mobile with the Instagram app installed.