Feat beautifier #1230
Feat beautifier #1230
Conversation
|
An editorconfig exists in the repository, which addresses code style. The fact that you ran into this issue is a documentation problem, in my opinion. I'm not sure if |
|
@hkal, the editorconfig is not honored by every editor, that's why i think a jsbeautify does not hurt. that way you are not dependent on the editor but more on your build process or global commands if you prefer i remove it though i don't have any objection |
|
Could you add the jsbeatify script to the package.json scripts? |
|
@sokra not sure what you mean by that... |
|
Something like |
|
Thanks |
|
I hope I'll be able to merge this with the webpack-2 branch... |
|
I improved the PR a bit: e68108a It now checks for beauty files on CI and npm test |
Motivation
during my first PR to this repo i struggled with the tab convention over space, and had to re push a few times.
the command
npm run lintshould have told me what was wrong before i pushed to the repo...Changes
.eslintrcto make it obvious that code adhere to the repo.jsbeautyrcfile following code style so it is easier to reformat the code when contributing (using js-beautify or any code editor plugin built on top of it)