Skip to content

chore: refactor plugin name #19456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

chore: refactor plugin name #19456

merged 1 commit into from
Apr 23, 2025

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 23, 2025 •
edited
Loading

What kind of change does this PR introduce?

Refactor and move plugin name to own const.

Why?

  • less indentation and better readable
  • ability to reuse plugin name for loggers/caches
  • easy to rename plugin - less mistakes when we forgot to change plugin name in hooks

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No need

@github-actions GitHub Actions
Copy link

Benchmarks:

  • "devtool-source-map": HEAD (2eff6cb) 674 ms ± 49 ms [662 ms; 685 ms] (49 runs)
  • "devtool-source-map": BASE (d988515) 667 ms ± 42 ms [657 ms; 677 ms] (49 runs)
  • "devtool-source-map" change: HEAD (674 ms ± 49 ms [662 ms; 685 ms]) is -1% the same as BASE (BASE) (667 ms ± 42 ms [657 ms; 677 ms])
  • "many-chunks": HEAD (2eff6cb) 1115 ms ± 43 ms [1101 ms; 1128 ms] (31 runs)
  • "many-chunks": BASE (d988515) 1099 ms ± 49 ms [1084 ms; 1114 ms] (32 runs)
  • "many-chunks" change: HEAD (1115 ms ± 43 ms [1101 ms; 1128 ms]) is -1% the same as BASE (BASE) (1099 ms ± 49 ms [1084 ms; 1114 ms])
  • "many-modules": HEAD (2eff6cb) 611 ms ± 29 ms [604 ms; 618 ms] (53 runs)
  • "many-modules": BASE (d988515) 613 ms ± 30 ms [606 ms; 620 ms] (53 runs)
  • "many-modules" change: HEAD (611 ms ± 29 ms [604 ms; 618 ms]) is 0% the same as BASE (BASE) (613 ms ± 30 ms [606 ms; 620 ms])
  • "popular-libraries": HEAD (2eff6cb) 1515 ms ± 33 ms [1503 ms; 1526 ms] (24 runs)
  • "popular-libraries": BASE (d988515) 1562 ms ± 41 ms [1548 ms; 1576 ms] (24 runs)
  • "popular-libraries" change: HEAD (1515 ms ± 33 ms [1503 ms; 1526 ms]) is 3% faster than BASE (BASE) (1562 ms ± 41 ms [1548 ms; 1576 ms])

@alexander-akait alexander-akait merged commit 52dc193 into main Apr 23, 2025
57 of 58 checks passed
@alexander-akait alexander-akait deleted the refactor-plugin-name branch April 23, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexander-akait