Skip to content

fix: avoid module concatenation in child compilation for module library #19457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

fix: avoid module concatenation in child compilation for module library #19457

merged 2 commits into from
Apr 23, 2025

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

fixes #19452

Did you add tests for your changes?

WIP

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

Benchmarks:

  • "devtool-source-map": HEAD (d3c32b0) 643 ms ± 44 ms [632 ms; 653 ms] (51 runs)
  • "devtool-source-map": BASE (52dc193) 632 ms ± 42 ms [622 ms; 642 ms] (52 runs)
  • "devtool-source-map" change: HEAD (643 ms ± 44 ms [632 ms; 653 ms]) is -2% the same as BASE (BASE) (632 ms ± 42 ms [622 ms; 642 ms])
  • "many-chunks": HEAD (d3c32b0) 1075 ms ± 36 ms [1064 ms; 1086 ms] (32 runs)
  • "many-chunks": BASE (52dc193) 1076 ms ± 31 ms [1067 ms; 1086 ms] (32 runs)
  • "many-chunks" change: HEAD (1075 ms ± 36 ms [1064 ms; 1086 ms]) is 0% the same as BASE (BASE) (1076 ms ± 31 ms [1067 ms; 1086 ms])
  • "many-modules": HEAD (d3c32b0) 585 ms ± 28 ms [579 ms; 592 ms] (55 runs)
  • "many-modules": BASE (52dc193) 586 ms ± 32 ms [579 ms; 593 ms] (55 runs)
  • "many-modules" change: HEAD (585 ms ± 28 ms [579 ms; 592 ms]) is 0% the same as BASE (BASE) (586 ms ± 32 ms [579 ms; 593 ms])
  • "popular-libraries": HEAD (d3c32b0) 1437 ms ± 20 ms [1430 ms; 1444 ms] (25 runs)
  • "popular-libraries": BASE (52dc193) 1444 ms ± 26 ms [1435 ms; 1453 ms] (25 runs)
  • "popular-libraries" change: HEAD (1437 ms ± 20 ms [1430 ms; 1444 ms]) is 0% the same as BASE (BASE) (1444 ms ± 26 ms [1435 ms; 1453 ms])

@alexander-akait alexander-akait merged commit 519187b into main Apr 23, 2025
53 of 58 checks passed
@alexander-akait alexander-akait deleted the issue-19452 branch April 23, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.99.0+ breaks @vanilla-extract/webpack-plugin
1 participant
@alexander-akait