Skip to content

fix: better types #19469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

fix: better types #19469

merged 2 commits into from
Apr 25, 2025

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 25, 2025 •
edited
Loading

What kind of change does this PR introduce?

bugfix - better types

Did you add tests for your changes?

No need

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@alexander-akait
Copy link
Member Author

Benchmarks:

  • "devtool-source-map": HEAD (04de35c) 664 ms ± 51 ms [652 ms; 676 ms] (50 runs)
  • "devtool-source-map": BASE (9a0e0ea) 657 ms ± 41 ms [647 ms; 667 ms] (50 runs)
  • "devtool-source-map" change: HEAD (664 ms ± 51 ms [652 ms; 676 ms]) is -1% the same as BASE (BASE) (657 ms ± 41 ms [647 ms; 667 ms])
  • "many-chunks": HEAD (04de35c) 1096 ms ± 41 ms [1084 ms; 1109 ms] (32 runs)
  • "many-chunks": BASE (9a0e0ea) 1087 ms ± 38 ms [1075 ms; 1098 ms] (32 runs)
  • "many-chunks" change: HEAD (1096 ms ± 41 ms [1084 ms; 1109 ms]) is -1% the same as BASE (BASE) (1087 ms ± 38 ms [1075 ms; 1098 ms])
  • "many-modules": HEAD (04de35c) 605 ms ± 28 ms [599 ms; 612 ms] (54 runs)
  • "many-modules": BASE (9a0e0ea) 603 ms ± 26 ms [597 ms; 608 ms] (54 runs)
  • "many-modules" change: HEAD (605 ms ± 28 ms [599 ms; 612 ms]) is 0% the same as BASE (BASE) (603 ms ± 26 ms [597 ms; 608 ms])
  • "popular-libraries": HEAD (04de35c) 1561 ms ± 30 ms [1550 ms; 1571 ms] (24 runs)
  • "popular-libraries": BASE (9a0e0ea) 1514 ms ± 48 ms [1497 ms; 1531 ms] (24 runs)
  • "popular-libraries" change: HEAD (1561 ms ± 30 ms [1550 ms; 1571 ms]) is -3% slower than BASE (BASE) (1514 ms ± 48 ms [1497 ms; 1531 ms])

@alexander-akait
Copy link
Member Author

Benchmarks:

  • "devtool-source-map": HEAD (de665ea) 648 ms ± 49 ms [637 ms; 660 ms] (51 runs)
  • "devtool-source-map": BASE (9a0e0ea) 636 ms ± 41 ms [627 ms; 646 ms] (52 runs)
  • "devtool-source-map" change: HEAD (648 ms ± 49 ms [637 ms; 660 ms]) is -2% the same as BASE (BASE) (636 ms ± 41 ms [627 ms; 646 ms])
  • "many-chunks": HEAD (de665ea) 1084 ms ± 36 ms [1073 ms; 1095 ms] (32 runs)
  • "many-chunks": BASE (9a0e0ea) 1095 ms ± 44 ms [1082 ms; 1109 ms] (32 runs)
  • "many-chunks" change: HEAD (1084 ms ± 36 ms [1073 ms; 1095 ms]) is 1% the same as BASE (BASE) (1095 ms ± 44 ms [1082 ms; 1109 ms])
  • "many-modules": HEAD (de665ea) 596 ms ± 28 ms [589 ms; 602 ms] (54 runs)
  • "many-modules": BASE (9a0e0ea) 599 ms ± 27 ms [593 ms; 605 ms] (54 runs)
  • "many-modules" change: HEAD (596 ms ± 28 ms [589 ms; 602 ms]) is 1% the same as BASE (BASE) (599 ms ± 27 ms [593 ms; 605 ms])
  • "popular-libraries": HEAD (de665ea) 1486 ms ± 29 ms [1476 ms; 1496 ms] (25 runs)
  • "popular-libraries": BASE (9a0e0ea) 1475 ms ± 32 ms [1464 ms; 1486 ms] (25 runs)
  • "popular-libraries" change: HEAD (1486 ms ± 29 ms [1476 ms; 1496 ms]) is -1% the same as BASE (BASE) (1475 ms ± 32 ms [1464 ms; 1486 ms])

@alexander-akait alexander-akait merged commit 9e0339d into main Apr 25, 2025
53 of 58 checks passed
@alexander-akait alexander-akait deleted the fix-types branch April 25, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexander-akait