Skip to content

chore: add nodejs-addons example #19475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

chore: add nodejs-addons example #19475

merged 4 commits into from
Apr 28, 2025

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

chore

Did you add tests for your changes?

No need

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@alexander-akait
Copy link
Member Author

Benchmarks:

  • "devtool-source-map": HEAD (0333c67) 631 ms ± 47 ms [620 ms; 642 ms] (52 runs)
  • "devtool-source-map": BASE (7d7d703) 623 ms ± 39 ms [614 ms; 632 ms] (52 runs)
  • "devtool-source-map" change: HEAD (631 ms ± 47 ms [620 ms; 642 ms]) is -1% the same as BASE (BASE) (623 ms ± 39 ms [614 ms; 632 ms])
  • "many-chunks": HEAD (0333c67) 1065 ms ± 31 ms [1056 ms; 1075 ms] (33 runs)
  • "many-chunks": BASE (7d7d703) 1060 ms ± 35 ms [1050 ms; 1071 ms] (33 runs)
  • "many-chunks" change: HEAD (1065 ms ± 31 ms [1056 ms; 1075 ms]) is 0% the same as BASE (BASE) (1060 ms ± 35 ms [1050 ms; 1071 ms])
  • "many-modules": HEAD (0333c67) 573 ms ± 28 ms [567 ms; 579 ms] (56 runs)
  • "many-modules": BASE (7d7d703) 569 ms ± 23 ms [564 ms; 574 ms] (57 runs)
  • "many-modules" change: HEAD (573 ms ± 28 ms [567 ms; 579 ms]) is -1% the same as BASE (BASE) (569 ms ± 23 ms [564 ms; 574 ms])
  • "popular-libraries": HEAD (0333c67) 1410 ms ± 21 ms [1403 ms; 1417 ms] (26 runs)
  • "popular-libraries": BASE (7d7d703) 1418 ms ± 29 ms [1408 ms; 1427 ms] (26 runs)
  • "popular-libraries" change: HEAD (1410 ms ± 21 ms [1403 ms; 1417 ms]) is 1% the same as BASE (BASE) (1418 ms ± 29 ms [1408 ms; 1427 ms])

@alexander-akait
Copy link
Member Author

Benchmarks:

  • "devtool-source-map": HEAD (1388996) 637 ms ± 50 ms [625 ms; 648 ms] (52 runs)
  • "devtool-source-map": BASE (7d7d703) 628 ms ± 41 ms [618 ms; 637 ms] (52 runs)
  • "devtool-source-map" change: HEAD (637 ms ± 50 ms [625 ms; 648 ms]) is -1% the same as BASE (BASE) (628 ms ± 41 ms [618 ms; 637 ms])
  • "many-chunks": HEAD (1388996) 1077 ms ± 32 ms [1068 ms; 1086 ms] (32 runs)
  • "many-chunks": BASE (7d7d703) 1073 ms ± 33 ms [1063 ms; 1083 ms] (32 runs)
  • "many-chunks" change: HEAD (1077 ms ± 32 ms [1068 ms; 1086 ms]) is 0% the same as BASE (BASE) (1073 ms ± 33 ms [1063 ms; 1083 ms])
  • "many-modules": HEAD (1388996) 585 ms ± 34 ms [578 ms; 593 ms] (55 runs)
  • "many-modules": BASE (7d7d703) 583 ms ± 25 ms [577 ms; 589 ms] (55 runs)
  • "many-modules" change: HEAD (585 ms ± 34 ms [578 ms; 593 ms]) is 0% the same as BASE (BASE) (583 ms ± 25 ms [577 ms; 589 ms])
  • "popular-libraries": HEAD (1388996) 1438 ms ± 26 ms [1429 ms; 1447 ms] (25 runs)
  • "popular-libraries": BASE (7d7d703) 1434 ms ± 34 ms [1422 ms; 1446 ms] (25 runs)
  • "popular-libraries" change: HEAD (1438 ms ± 26 ms [1429 ms; 1447 ms]) is 0% the same as BASE (BASE) (1434 ms ± 34 ms [1422 ms; 1446 ms])

@alexander-akait alexander-akait mentioned this pull request Apr 28, 2025
Open
@alexander-akait
Copy link
Member Author

Benchmarks:

  • "devtool-source-map": HEAD (2c21e6f) 645 ms ± 48 ms [634 ms; 656 ms] (51 runs)
  • "devtool-source-map": BASE (7d7d703) 633 ms ± 43 ms [623 ms; 643 ms] (52 runs)
  • "devtool-source-map" change: HEAD (645 ms ± 48 ms [634 ms; 656 ms]) is -2% the same as BASE (BASE) (633 ms ± 43 ms [623 ms; 643 ms])
  • "many-chunks": HEAD (2c21e6f) 1085 ms ± 38 ms [1074 ms; 1096 ms] (32 runs)
  • "many-chunks": BASE (7d7d703) 1078 ms ± 28 ms [1070 ms; 1087 ms] (32 runs)
  • "many-chunks" change: HEAD (1085 ms ± 38 ms [1074 ms; 1096 ms]) is -1% the same as BASE (BASE) (1078 ms ± 28 ms [1070 ms; 1087 ms])
  • "many-modules": HEAD (2c21e6f) 591 ms ± 25 ms [586 ms; 597 ms] (55 runs)
  • "many-modules": BASE (7d7d703) 589 ms ± 25 ms [583 ms; 594 ms] (55 runs)
  • "many-modules" change: HEAD (591 ms ± 25 ms [586 ms; 597 ms]) is 0% the same as BASE (BASE) (589 ms ± 25 ms [583 ms; 594 ms])
  • "popular-libraries": HEAD (2c21e6f) 1481 ms ± 35 ms [1469 ms; 1493 ms] (25 runs)
  • "popular-libraries": BASE (7d7d703) 1489 ms ± 29 ms [1480 ms; 1499 ms] (25 runs)
  • "popular-libraries" change: HEAD (1481 ms ± 35 ms [1469 ms; 1493 ms]) is 1% the same as BASE (BASE) (1489 ms ± 29 ms [1480 ms; 1499 ms])

@alexander-akait alexander-akait merged commit 88e1c83 into main Apr 28, 2025
38 of 58 checks passed
@alexander-akait alexander-akait deleted the nodejs-addons branch April 28, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexander-akait