HMR support for ESM #19561
Draft
HMR support for ESM #19561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
289c5ec to
c4159c4
Compare
67abe1c to
2ee3111
Compare
| RuntimeGlobals.hasOwnProperty | ||
| ]) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Do we really need this here? I think we should add them in ModuleChunkLoadingPlugin.js. Can you provide more information here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Hot Module Replacement (HMR) support for ESM output format. Currently, when using
experiments.outputModule: true, HMR throws an errorHMR is not implemented for module chunk format yetand prevents developers from using HMR with ESM builds.What kind of change does this PR introduce?
This is a feature implementation that enables HMR functionality for ESM output format. The changes include:
ModuleChunkFormatPluginto generate ESM-formatted hot update chunksModuleChunkLoadingPluginto register HMR handlers for ESMimport()-based hot update loading inModuleChunkLoadingRuntimeModuleHotModuleReplacementPluginfor ESM chunksDid you add tests for your changes?
Tests will be added to cover:
Does this PR introduce a breaking change?
No, this change is backward compatible. It only affects builds that explicitly enable both ESM output (
experiments.outputModule: true) and HMR, which previously resulted in an error.What needs to be documented once your changes are merged?