fix: needCreateRequire should be set to true only when module output and node target
#19761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #19761 will degrade performances by 94.03%Comparing Summary
Benchmarks breakdown
|
4c95d99 to
4026dcd
Compare
__non_webpack_require__ when module output but target is not nodeneedCreateRequire should be set to true only when module output and node target
4026dcd to
97499fb
Compare
97499fb to
de29b5e
Compare
lib/APIPlugin.js
Outdated
| importMetaName | ||
| ); | ||
| const moduleOutput = compilation.options.output.module; | ||
| const nodeTarget = compilation.options.externalsPresets.node; |
There was a problem hiding this comment.
Better to use compiler.platform.node to check is it node target or not, don't forget we have target: ['web', 'node'] (i.e. universal target, it is not fully ready right now, but we should finish it soon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #19441.
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No