Skip to content

fix: types for plugins #19785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

fix: types for plugins #19785

merged 1 commit into from
Aug 11, 2025

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfix - export types to create own module types

Did you add tests for your changes?

No need

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19785 will degrade performances by 76.89%

Comparing fix-types-for-plugins (6eddf3b) with main (e3c48f5)1

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 5,079.3 ms 361.4 ms ×14
⚡ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 86.2 ms 44.5 ms +93.78%
❌ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 51.8 ms 115.2 ms -54.99%
❌ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 94.5 ms 409 ms -76.89%
⚡ benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 5,351.3 ms 308.5 ms ×17

Footnotes

  1. No successful run was found on main (cbacdf1) during the generation of this report, so e3c48f5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@alexander-akait alexander-akait merged commit de39337 into main Aug 11, 2025
41 of 44 checks passed
@alexander-akait alexander-akait deleted the fix-types-for-plugins branch August 11, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexander-akait