feat(moduletemplate): Wrap function module template wrappers with parens #3661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back-ports c7b06ad (webpack#3658) to webpack-1 based on https://twitter.com/TheLarkInn/status/815230804729196544.
|
|
Current coverage is 11.76% (diff: 100%)@@ webpack-1 #3661 diff @@
===========================================
Files 1 1
Lines 34 34
Methods 5 5
Messages 0 0
Branches 6 6
===========================================
Hits 4 4
Misses 30 30
Partials 0 0
|
|
I should note that |
|
@sokra would you mind reviewing this one. Since I haven't been involved with the v1 code I just want to ensure another pair of eyes on it before merging into stable v1. |
TheLarkInn
approved these changes
Dec 31, 2016
sokra
approved these changes
Jan 2, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No, just updated existing expected output.
If relevant, link to documentation update:
Summary
This back-ports c7b06ad to
webpack-1based on the Twitter thread for the original PR (#3658).Does this PR introduce a breaking change?
No
Other information
This is my first webpack PR, so please let me know if there's anything I need to fix!