require a newer version of uglify that fixes a bug with regexp #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gaearon |
|
trying to get the tests passing. i can't even run the master tests locally though. i get an Error: Cannot find module 'webpack/lib/removeAndDo' |
|
see CONTRIBUTING.md. To update the test snapshots: |
|
it's passing in travis but i still get an error locally.
|
bdwain
commented
May 19, 2017
| @@ -20,7 +20,7 @@ it("should pass mangle options", function() { | |||
| var fs = require("fs"), | |||
| path = require("path"); | |||
| var source = fs.readFileSync(path.join(__dirname, "ie8.js"), "utf-8"); | |||
| source.should.containEql("function r(n){return function(n){try{t()}catch(t){n(t)}}}"); | |||
| source.should.containEql("function r(n){return function(t){try{n()}catch(n){t(n)}}}"); | |||
There was a problem hiding this comment.
on second thought not sure i should have switched n and t. it looks like it might change the behavior of the resulting code. but i'm not sure why the output switched either.
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
May 20, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Just requiring a newer version of uglify js that includes a bugfix mishoo/UglifyJS#1964
Did you add tests for your changes?
No code changes were made.
Summary
There was a bug in earlier versions of uglify where the reduce_vars option (which is on by default) was causing some changes to the global RegExp prototype in certain scenarios (such as if babel-polyfill is included). This could break methods like string.split when using node 6 or chrome 51.
Does this PR introduce a breaking change?
No