Factory method for require dependency in AMDRequireDependenciesBlock #8544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
@ooflorent, thanks for approving. How does this get merged? |
sokra
approved these changes
Dec 30, 2018
|
Thanks Note that subclassing these classes is not part of the public API and may change in minor versions. Fix your webpack version if you are doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified re-submission of #8501 which was rejected because of concerns about the code being too tightly coupled with webpack internals. This submission contains only the change to add the factory method to AMDRequireDependenciesBlock.js. This change is consistent with existing patterns, including:
What kind of change does this PR introduce?
Refactoring in support of code reuse and extensibility
Did you add tests for your changes?
No, not needed. No functional changes.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
N/A
N/A