Skip to content

fix badly chosen max fill rate for deterministic #9849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2019
Merged

fix badly chosen max fill rate for deterministic #9849

merged 2 commits into from
Oct 17, 2019

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 16, 2019

sort modules by identifier in output file, that's better for gzip

What kind of change does this PR introduce?
bugfix, optimization

Did you add tests for your changes?
existing

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@sokra
fix badly chosen max fill rate for deterministic
65bdb43 
sort modules by identifier in output file, that's better for gzip
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 433da9e into master Oct 17, 2019
@sokra sokra deleted the bugfix/determinitic-ids-gzip branch October 17, 2019 13:42
@sokra sokra mentioned this pull request Oct 28, 2019
Closed
@alexzhang1030 alexzhang1030 mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @webpack-bot