Skip to content

chore(release): 4.0.0-rc.0 #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

rc release

Breaking Changes

No

Additional Info

/cc @hiroppy @Loonride please check my changelog, maybe I forgot something

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #586 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           8        8           
  Lines         228      228           
  Branches       71       71           
=======================================
  Hits          226      226           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0e46ad...a7d7711. Read the comment docs.

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of comments.

CHANGELOG.md Outdated
* the `outputFileSystem` option now correctly works in multi-compiler mode
* respect `[hash]`/`[fullhash]` in `output.path` and `output.publicPath`
* handle exceptions for filesystem operations
* the `Content-Type` header doesn't has `charset=utf-8` value for custom MIME types and MIME types which can be non `utf-8`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the `Content-Type` header doesn't has `charset=utf-8` value for custom MIME types and MIME types which can be non `utf-8`
* the `Content-Type` header doesn't have `charset=utf-8` value for custom MIME types and MIME types which can be non `utf-8`

CHANGELOG.md Outdated
### BREAKING CHANGES

* minimum supported Node.js version is `10.13.0`
* the default value of the option `publicPath` takes from the value of the `output.publicPath` option from the configuration (`webpack.config.js`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the default value of the option `publicPath` takes from the value of the `output.publicPath` option from the configuration (`webpack.config.js`)
* the default value of the option `publicPath` is taken from the value of the `output.publicPath` option from the configuration (`webpack.config.js`)

CHANGELOG.md Outdated

* minimum supported Node.js version is `10.13.0`
* the default value of the option `publicPath` takes from the value of the `output.publicPath` option from the configuration (`webpack.config.js`)
* the `stats` option was removed, the default value of the `stats` option takes from the value of the `stats` option from the configuration (`webpack.config.js`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the `stats` option was removed, the default value of the `stats` option takes from the value of the `stats` option from the configuration (`webpack.config.js`)
* the `stats` option was removed, the default value of the `stats` option is taken from the value of the `stats` option from the configuration (`webpack.config.js`)

CHANGELOG.md Outdated
* minimum supported Node.js version is `10.13.0`
* the default value of the option `publicPath` takes from the value of the `output.publicPath` option from the configuration (`webpack.config.js`)
* the `stats` option was removed, the default value of the `stats` option takes from the value of the `stats` option from the configuration (`webpack.config.js`)
* the `watchOptions` was removed, the default value of the `watchOptions` option takes from the value of the `watchOptions` option from the configuration (`webpack.config.js`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the `watchOptions` was removed, the default value of the `watchOptions` option takes from the value of the `watchOptions` option from the configuration (`webpack.config.js`)
* the `watchOptions` was removed, the default value of the `watchOptions` option is taken from the value of the `watchOptions` option from the configuration (`webpack.config.js`)

CHANGELOG.md Outdated
* the default value of the option `publicPath` takes from the value of the `output.publicPath` option from the configuration (`webpack.config.js`)
* the `stats` option was removed, the default value of the `stats` option takes from the value of the `stats` option from the configuration (`webpack.config.js`)
* the `watchOptions` was removed, the default value of the `watchOptions` option takes from the value of the `watchOptions` option from the configuration (`webpack.config.js`)
* the `Content-Type` header doesn't has `charset=utf-8` value for custom MIME types and MIME types which can be non `utf-8`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the `Content-Type` header doesn't has `charset=utf-8` value for custom MIME types and MIME types which can be non `utf-8`
* the `Content-Type` header doesn't have `charset=utf-8` value for custom MIME types and MIME types which can be non `utf-8`

CHANGELOG.md Outdated
* the `mimeTypes` option first requires you to specify an extension and then a content-type - `{ mimeTypes: { phtml: 'text/html' } }`
* the `force` option from the `mimeTypes` option was removed without replacement
* the `reporter` option was removed without replacement
* the `getFilenameFromUrl` method was removed from API

This comment was marked as resolved.

@alexander-akait
Copy link
Member Author

@jamesgeorge007 big thanks!

@alexander-akait alexander-akait force-pushed the chore-release-4.0.0-rc.0 branch from 942ddf8 to f0e46ad Compare February 19, 2020 11:29
@alexander-akait alexander-akait merged commit ae2dec9 into master Feb 19, 2020
@alexander-akait alexander-akait deleted the chore-release-4.0.0-rc.0 branch February 19, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants