Skip to content

refactor(bin): move options and helpers into separate files #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

michael-ciniawsky
Copy link
Member

Type

  • Refactor

Issues

  • None

SemVer

  • Patch

@codecov
Copy link

codecov bot commented Aug 26, 2018

Codecov Report

Merging #1470 into master will decrease coverage by 2.82%.
The diff coverage is 53.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   75.55%   72.72%   -2.83%     
==========================================
  Files           8       10       +2     
  Lines         679      726      +47     
==========================================
+ Hits          513      528      +15     
- Misses        166      198      +32
Impacted Files Coverage Δ
bin/options.js 100% <100%> (ø)
bin/utils.js 44.44% <44.44%> (ø)
bin/webpack-dev-server.js 56.52% <53.27%> (-6.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee13ab...9b016ae. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks windows tests broken 😞 We need fix their.

@michael-ciniawsky
Copy link
Member Author

AppVeyor failures are expected atm, since there is no setup yet (appveyor.yml) yet (#1468)

@michael-ciniawsky michael-ciniawsky deleted the refactor/bin branch August 27, 2018 18:29
@michael-ciniawsky michael-ciniawsky removed this from the 3.2.0 milestone Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants