add local copy of video and update src #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbtsao47
pushed a commit
to cbtsao47/JavaScript30
that referenced
this pull request
Nov 23, 2018
add local copy of video and update src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue halfway through where the video would consistently freeze after roughly 1m20s into the video (15%) due to network issues, while trying to implement the playback slider. It was not immediately obvious it was a network issue, until I disabled almost all of my code and just let it run and it still froze. A local copy saves bandwidth (only have to download it once) and prevents this issue. I also updated the video src in index.html.
(this is my first contribution to some else's work so I apologize if I flubbed some GitHub etiquette...Thanks for the awesome course!)