Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signal to addEventListener #919

Merged
merged 5 commits into from
Dec 3, 2020
Merged

add signal to addEventListener #919

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d67e335
add signal to addEventListener
benjamingr Nov 9, 2020
ab05ff3
more code review
benjamingr Dec 1, 2020
5266342
nits
annevk Dec 2, 2020
b2df711
make the one other event listener dictionary thing consistent
annevk Dec 2, 2020
0699e74
add myself to acks
benjamingr Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nits
  • Loading branch information
@annevk
annevk committed Dec 2, 2020
commit 5266342d7c312d9cc7678227f3e15fb85e76ca8f
31 changes: 18 additions & 13 deletions dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ are not to be used for anything else. [[!HTML]]
<a for="event listener">callback</a> will only be invoked once after which the event listener will
be removed.

<p>If an {{AbortSignal}} is passed for <var>options</var>'s {{AddEventListenerOptions/signal}}
<p>If an {{AbortSignal}} is passed for <var>options</var>'s {{AddEventListenerOptions/signal}},
then the event listener will be removed when signal is aborted.

<p>The <a>event listener</a> is appended to <var>target</var>'s
Expand Down Expand Up @@ -1084,14 +1084,18 @@ steps:

<li><p>Let <var>once</var> and <var>passive</var> be false.

<li><p>Let <var>signal</var> be null.
<li><p>Let |signal| be null.

<li><p>If <var>options</var> is a dictionary, then set <var>passive</var> to <var>options</var>'s
<code>{{AddEventListenerOptions/passive}}</code> and <var>once</var> to <var>options</var>'s
<code>{{AddEventListenerOptions/once}}</code>.
<li>
<p>If |options| is a dictionary, then:

<ol>
<li><p>Set |passive| to |options|["{{AddEventListenerOptions/passive}}"] and |once| to
|options|["{{AddEventListenerOptions/once}}"].

<li><p>If |options| is a dictionary and |options|["{{AddEventListenerOptions/signal}}"] [=map/exists=],
then set |signal| to |options|["{{AddEventListenerOptions/signal}}"].
<li><p>If |options|["{{AddEventListenerOptions/signal}}"] [=map/exists=], then set |signal| to
|options|["{{AddEventListenerOptions/signal}}"].
</ol>

<li><p>Return <var>capture</var>, <var>passive</var>, <var>once</var>, and <var>signal</var>.
</ol>
Expand Down Expand Up @@ -1131,12 +1135,13 @@ participate in a tree structure.</p>
<var>listener</var>'s <a for="event listener">capture</a>, then <a for=list>append</a>
<var>listener</var> to <var>eventTarget</var>'s <a>event listener list</a>.

<li>
<p>If <a for="event listener">signal</a> is not null, then <a for=AbortSignal lt=add>add the following</a>
abort steps to it:
<ol>
<li><a>Remove an event listener</a> with <var>eventTarget</var> and <var>listener</var>.
</ol>
<li>
<p>If <var>listener</var>'s <a for="event listener">signal</a> is not null, then
<a for=AbortSignal lt=add>add the following</a> abort steps to it:

<ol>
<li><a>Remove an event listener</a> with <var>eventTarget</var> and <var>listener</var>.
</ol>
</ol>

<p class=note>The <a>add an event listener</a> concept exists to ensure <a>event handlers</a> use
Expand Down