Treat null fragment the same as an empty string in location hash setter #11245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f209e7 to
1fe5ca8
Compare
domenic
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
LGTM. Can you fill out the OP? Chromium and WebKit automatically count as interested, and most other boxes are no-ops for this small of a change, but filing or finding a Gecko bug seems worthwhile.
I'll also give other reviewers a few days in case they have comments before merging.
|
I'm not familiar with exactly how firefox issue tracker, but maybe https://bugzilla.mozilla.org/show_bug.cgi?id=1733797 could be reused? Looks like it is still open and relevant |
|
Yep, that'd be perfect, just leave them a comment pointing to this PR as well. |
shannonbooth
added a commit
to shannonbooth/ladybird
that referenced
this pull request
Apr 22, 2025
Corresponds to open merge request in HTML spec of whatwg/html#11245 and a WPT test change of web-platform-tests/wpt#52085.
shannonbooth
added a commit
to shannonbooth/ladybird
that referenced
this pull request
Apr 22, 2025
Corresponds to open merge request in HTML spec of whatwg/html#11245 and a WPT test change of web-platform-tests/wpt#52085.
tcl3
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Apr 23, 2025
Corresponds to open merge request in HTML spec of whatwg/html#11245 and a WPT test change of web-platform-tests/wpt#52085.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11243.
(See WHATWG Working Mode: Changes for more details.)
/nav-history-apis.html ( diff )