Set invoker for popover command attributes #11248
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes parameters to the show popover algorithm and includes the invoker parameter.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 23, 2025
We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 23, 2025
We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 23, 2025
We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481415 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1450757}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 23, 2025
We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481415 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1450757}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 23, 2025
We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481415 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1450757}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 25, 2025
…ttributes, a=testonly Automatic update from web-platform-tests Add WPT for popover invoker on command attributes We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481415 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1450757} -- wpt-commits: 21a49888f9625da31db6e6cc0f611a69033329ea wpt-pr: 52129
sadym-chromium
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 28, 2025
We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481415 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1450757}
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Apr 29, 2025
…ttributes, a=testonly Automatic update from web-platform-tests Add WPT for popover invoker on command attributes We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481415 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1450757} -- wpt-commits: 21a49888f9625da31db6e6cc0f611a69033329ea wpt-pr: 52129
shtrom
pushed a commit
to mozilla-firefox/infra-testing
that referenced
this pull request
Apr 29, 2025
…ttributes, a=testonly Automatic update from web-platform-tests Add WPT for popover invoker on command attributes We set the popover invoker when using command attributes to invoke a popover, but there are no tests for this and the spec is missing it. Spec PR: whatwg/html#11248 Change-Id: I36b60cc1925376c6ecf5c7f9e72d7b955cae71cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6481415 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1450757} -- wpt-commits: 21a49888f9625da31db6e6cc0f611a69033329ea wpt-pr: 52129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes parameters to the show popover algorithm and includes the invoker parameter in the command attribute steps.
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )