-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Ensure modal dialogs can nest inside of hint popovers #11253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ensure modal dialogs can nest inside of hint popovers #11253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for putting this up!
Thanks for this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorially LGTM, but can you fill out the checkboxes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the specification is out of line with multiple implementations and the implementations are aligned, there's generally no need to seek implementer interest. (Also, in this case you had interest from Chromium and presumably you could have given interest from Gecko.) (But also, it's fine to ask regardless. I thought to share this in case it's useful in the future.)
You do need to fix the duplicate "or".
Oh, this is not the case I thought it was as Gecko and WebKit do not support In that case I'm going to defer to @nt1m for WebKit, but this is probably fine. |
Could Ladybird count as an "interested implementer" for this? |
This change allows for dialogs that are nested inside of a
hint
popover to be shown as modal. The current spec, as written, means that dialogs may close their parent hint popover causing issues similar to #9998. This change makes it such that a dialog (or fullscreen element) is a viable candidate to nest inside of a hint popover.This behaviour is exhibited in all major engines (which currently allow modal dialogs to nest inside of hint popovers) including Chrome, making this change normative.
This closes #11008, by making the spec modifications @Gingeh suggests in that issue.
(See WHATWG Working Mode: Changes for more details.)
/popover.html ( diff )