Make command events not composed #11255
Conversation
Based on feedback here, there may be a better alternative to making this event composed: whatwg#11148
|
I assume tests will need to be updated too? |
In particular https://github.com/web-platform-tests/wpt/blob/master/html/semantics/the-button-element/command-and-commandfor/button-event-dispatch.html will need to be refactored. |
There was a problem hiding this comment.
This is editorially fine. OP needs to be completed and I recall @smaug---- raising concerns about this earlier. Is he okay with this now?
|
If we are planning to change .source attribute handling to be similar to .relatedTarget, then this is fine (event would propagate if .target and .source are in different subtrees). |
|
@alice has been exploring solutions for reference target #11148 (comment) |
Is this something relatedTarget does? I was trying to understand how related target affects event propagation, but I couldn't decipher it from the text. |
|
If we want to make it work similar to relatedTarget that would be a bit more work. See https://dom.spec.whatwg.org/#concept-event-dispatch for how we deal with relatedTarget today. |
|
@annevk Could you explain how relatedTarget affects dispatch in non-spec terms? I've read through the spec a bunch of times, but I'm sadly none the wiser. |
|
At this point I would have to deduce it from first principles again as well I'm afraid. |
Based on feedback here, there may be a better alternative to making this event composed and we should remove composed now: #11148
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )