Update file upload control rendering to require a real button element #11257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepharhar
reviewed
Apr 24, 2025
josepharhar
reviewed
Apr 24, 2025
| files</span>, if any, followed by a <span>button</span> element that, when activated, provides the | ||
| user with a file picker from which the selection can be changed. The button is expected to use | ||
| <span>button layout</span> and match the <span>'::file-selector-button'</span> pseudo-element. The | ||
| contents of its <span>anonymous button content box</span> are expected to be |
There was a problem hiding this comment.
Not sure if we should still say "anonymous button content box" if we are explicitly saying that its a button element
There was a problem hiding this comment.
Yeah I'm not sure about the button layout bit either.
There was a problem hiding this comment.
@zcorpan can probably help us out here.
There was a problem hiding this comment.
https://html.spec.whatwg.org/#the-button-element-2 already requires button elements to have button layout, so no need to require it again here.
|
I am supportive of this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update file upload control rendering to require a real button element for ::file-selector-button
This ensures that it works work interopably as they're an element-backed pseudo-element.
Fixes #11130
(See WHATWG Working Mode: Changes for more details.)
/rendering.html ( diff )