ci: disable enterprise e2e tests temporarily (coder#12874)

aslilac · web-flow · commit bc9ea61eb45a · 2024-04-04T17:39:07.000-06:00
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -478,13 +478,6 @@ jobs:
           DEBUG: pw:api
         working-directory: site
 
-      # Run all of the tests with an enterprise license
-      - run: pnpm playwright:test --forbid-only --workers 1
-        env:
-          DEBUG: pw:api
-          CODER_E2E_ENTERPRISE_LICENSE: ${{ secrets.CODER_E2E_ENTERPRISE_LICENSE }}
-        working-directory: site
-
       - name: Upload Playwright Failed Tests
         if: always() && github.actor != 'dependabot[bot]' && runner.os == 'Linux' && !github.event.pull_request.head.repo.fork
         uses: actions/upload-artifact@v4
diff --git a/site/e2e/playwright.config.ts b/site/e2e/playwright.config.ts
@@ -1,6 +1,12 @@
 import { defineConfig } from "@playwright/test";
 import * as path from "path";
-import { coderMain, coderPort, coderdPProfPort, gitAuth } from "./constants";
+import {
+  coderMain,
+  coderPort,
+  coderdPProfPort,
+  enterpriseLicense,
+  gitAuth,
+} from "./constants";
 
 export const wsEndpoint = process.env.CODER_E2E_WS_ENDPOINT;
 
@@ -43,17 +49,22 @@ export default defineConfig({
   },
   webServer: {
     url: `http://localhost:${coderPort}/api/v2/deployment/config`,
-    command:
-      `go run -tags embed ${coderMain} server ` +
-      `--global-config $(mktemp -d -t e2e-XXXXXXXXXX) ` +
-      `--access-url=http://localhost:${coderPort} ` +
-      `--http-address=localhost:${coderPort} ` +
-      `--in-memory --telemetry=false ` +
-      `--dangerous-disable-rate-limits ` +
-      `--provisioner-daemons 10 ` +
-      `--provisioner-daemons-echo ` +
-      `--web-terminal-renderer=dom ` +
-      `--pprof-enable`,
+    command: [
+      `go run -tags embed ${coderMain} server`,
+      "--global-config $(mktemp -d -t e2e-XXXXXXXXXX)",
+      `--access-url=http://localhost:${coderPort}`,
+      `--http-address=localhost:${coderPort}`,
+      // Adding an enterprise license causes issues with pgcoord when running with `--in-memory`.
+      !enterpriseLicense && "--in-memory",
+      "--telemetry=false",
+      "--dangerous-disable-rate-limits",
+      "--provisioner-daemons 10",
+      "--provisioner-daemons-echo",
+      "--web-terminal-renderer=dom",
+      "--pprof-enable",
+    ]
+      .filter(Boolean)
+      .join(" "),
     env: {
       ...process.env,
 
diff --git a/site/e2e/tests/updateTemplate.spec.ts b/site/e2e/tests/updateTemplate.spec.ts
@@ -42,7 +42,7 @@ test("add and remove a group", async ({ page }) => {
 
   // Now remove the group
   await row.getByLabel("More options").click();
-  await page.getByText("Delete").click();
+  await page.getByText("Remove").click();
   await expect(page.getByText("Group removed successfully!")).toBeVisible();
   await expect(row).not.toBeVisible();
 });
