ci: disable --in-memory for enterprise e2e tests
#12874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed here: #12919 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment in the code says,
--in-memorycauses issues with pgcoord when there's an active enterprise license.Plus it's probably good to test with Postgres anyway? We only spin up a single instance so it shouldn't really be a perf concern. We can always revert later though, once the pgcoord issues are sorted out.
(Also fixes a test that got out of sync, and skips a currently failing test because there was a miscommunication about whether the license secret had actually been setup or not, and now that it's actually been added it's broken some stuff. 🙃)