Skip to content

Publish package with type definitions #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 28, 2021
Merged

Conversation

wimpyprogrammer
Copy link
Owner

Version 2.0.2 mistakenly lacks type definitions.

@wimpyprogrammer wimpyprogrammer added the bug Something isn't working label Mar 27, 2021
@wimpyprogrammer wimpyprogrammer self-assigned this Mar 27, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #15 (074a24c) into develop (13d3c94) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #15      +/-   ##
===========================================
+ Coverage    99.21%   99.52%   +0.31%     
===========================================
  Files           22       22              
  Lines          383      424      +41     
  Branches        60       68       +8     
===========================================
+ Hits           380      422      +42     
  Misses           2        2              
+ Partials         1        0       -1     
Impacted Files Coverage Δ
src/transforms/utils.ts 100.00% <ø> (+16.66%) ⬆️
src/expanders/character-class-pattern.ts 100.00% <100.00%> (ø)
src/expanders/disjunction-pattern.ts 100.00% <100.00%> (ø)
src/expanders/repetition-pattern.ts 100.00% <100.00%> (ø)
src/helpers/iterate-sorted.ts 100.00% <100.00%> (ø)
src/pattern.ts 100.00% <100.00%> (ø)
...ransforms/decimal-char-to-simple-char-transform.ts 100.00% <100.00%> (ø)
src/transforms/index.ts 100.00% <100.00%> (ø)
src/transforms/meta-to-char-class-transform.ts 100.00% <100.00%> (ø)
...simple-quantifier-to-range-quantifier-transform.ts 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d3c94...074a24c. Read the comment docs.

Validate the @ts-expect-error directives in e2e.spec.ts
Fix Snyk check failing due to SNYK-JS-LODASH-1040724.

Replace publish-please with release-it.
TypeScript performs all transpilation.
escape-string-regex includes types.
This is unneeded after removing the prepublishOnly script.
@wimpyprogrammer wimpyprogrammer changed the base branch from develop to main March 28, 2021 13:35
@wimpyprogrammer wimpyprogrammer merged commit 68322db into main Mar 28, 2021
@wimpyprogrammer wimpyprogrammer deleted the hotfix/missing-types branch March 28, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant