Skip to content

[CFE] Add i18n support to NOX and NOX in LYS step labels #59932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

[CFE] Add i18n support to NOX and NOX in LYS step labels #59932

merged 1 commit into from
Jul 23, 2025
+52 −18

Conversation

mordeth
Copy link
Contributor

@mordeth mordeth commented Jul 23, 2025

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR cherry-picks the following trunk-merged PRs:

How to test the changes in this Pull Request:

Go through the testing instructions of the following PRs but use this PR's branch instead of the original one:

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@mordeth @vladolaru
Add i18n support to NOX and NOX in LYS step labels (#59893)
574ca01 
* Add i18n support to NOX and NOX in LYS step labels

---------

Co-authored-by: Vlad Olaru <vlad.olaru@automattic.com>
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 23, 2025
@mordeth mordeth self-assigned this Jul 23, 2025
@mordeth mordeth requested a review from a team July 23, 2025 13:43
@github-actions GitHub Actions
Copy link
Contributor

Testing Guidelines

Hi @woocommerce/moltres,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

@github-actions GitHub Actions
Copy link
Contributor

Size Change: +109 B (0%)

Total Size: 5.91 MB

compressed-size-action

@github-actions GitHub Actions
Copy link
Contributor

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

vladolaru
vladolaru approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@vladolaru vladolaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are the same as the original PR and the testing checked out.

@mordeth mordeth merged commit ffe4d24 into release/10.1 Jul 23, 2025
30 checks passed
@mordeth mordeth deleted the cfe/fix/I18N-264-nox-steps-labels-localization branch July 23, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladolaru vladolaru vladolaru approved these changes

Assignees

@mordeth mordeth

Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mordeth @vladolaru