Added .gitignore and .editorconfig files #15
Conversation
| /site | ||
|
|
||
| # mypy | ||
| .mypy_cache/ |
There was a problem hiding this comment.
Please add a newline at the end. It's a common standard to end files with a newline. https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
.editorconfig
Outdated
| insert_final_newline = true | ||
|
|
||
| # 4 space indentation | ||
| [*.{ini,py,py.tpl,rst}] |
There was a problem hiding this comment.
We don't have any ini or .tpl or .rst files currently in the project.
There was a problem hiding this comment.
Please cross check what all files do we have currently in the repo, and adapt accordingly
.editorconfig
Outdated
| indent_size = 4 | ||
|
|
||
| # 4-width tabbed indentation | ||
| [*.{sh,bat.tpl,Makefile.tpl}] |
There was a problem hiding this comment.
Again, there are no such files present. We can add such entries later once we have these files in the codebase. I hope you get the idea :)
|
It seems that your commit message doesn't contain enough information. Don't worry, most people don't know about good commit messages initially, including very experienced developers :) Standards vary from project to project. The most important part is the first line of your commit message - we can use it to read through a large number of commits and thus it's important that it's short but most importantly concise. I'd heartily recommend reading http://coala.io/commit ! To change your message you just use Cheers! |
|
Please now review my PR. I have made the changes requested by mentors. |
| @@ -0,0 +1,14 @@ | |||
| # EditorConfig is awesome: http://EditorConfig.org | |||
There was a problem hiding this comment.
We don't need this line :p
| [*.{py}] | ||
| indent_style = space | ||
| indent_size = 4 | ||
|
|
There was a problem hiding this comment.
This is one extra line than blank line :)
|
Also, did you see #15 (comment) ? |
|
In what way I should change my commit message?? |
|
Commit 1 Commit 2 |
|
@pritamnegi I suggest you take a look at Github's gitignore as well to check if we need something more for our project. Also, make sure your PR description is informative enough. |
|
Ok as you say @realslimshanky |
#13