-
Notifications
You must be signed in to change notification settings - Fork 12
created Contributing.md #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Pallavi024 please squash your commits. |
@realslimshanky I have squashed my commits...please take a look at it 😄 |
@@ -0,0 +1,141 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a heading here like 'Contribution Guide - WTF'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@realslimshanky I apologise for the delay.I have made the required changes
Contributing.md
Outdated
|
||
$ git branch | ||
|
||
Your current branch will have an asterisk (*) next to it. Ensure that there is no asterisk next to the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This asterisk should be escaped. It is making all the trailing text in Italics style.
Contributing.md
Outdated
@@ -0,0 +1,141 @@ | |||
# Contribution Guide -WTF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space around -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also WTFpython contribution guide
sounds better to me.
098abf4
to
820523b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NOTE:
Please fill out the template below
Did you read the instructions in the WORKFLOW ?
Is your Python code styled according to the PEP8 code style convention as mentioned here ?
Have you run the tests ?
Have you followed commit guidelines as mentioned here ?