This repository was archived by the owner on May 1, 2024. It is now read-only.
Cleanup pipeline #1845
Merged
Cleanup pipeline #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a81849 to
f2bbc91
Compare
f2bbc91 to
49707cf
Compare
52e2aad to
b6ffd36
Compare
| @@ -175,10 +175,8 @@ void SetColor() | |||
|
|
|||
| flyoutStyle.Setters.Add(new Windows.UI.Xaml.Setter(FlyoutPresenter.BackgroundProperty, Element.Color.ToWindowsColor())); | |||
|
|
|||
| #if UWP_18362 | |||
There was a problem hiding this comment.
we already have min version 18362. no need to check
| @@ -45,19 +45,7 @@ | |||
| <UseWindowsForms>true</UseWindowsForms> | |||
| </PropertyGroup> | |||
| <PropertyGroup Condition=" $(TargetFramework.StartsWith('uap10.0')) "> | |||
| <DefineConstants>$(DefineConstants);UAP10_0</DefineConstants> | |||
| </PropertyGroup> | |||
| <PropertyGroup Condition="'$(TargetFramework)' == 'uap10.0.14393'"> | |||
There was a problem hiding this comment.
unused target frameworks
| @@ -62,15 +62,6 @@ jobs: | |||
| pool: | |||
| vmImage: windows-2019 | |||
| steps: | |||
| - task: CmdLine@2 | |||
There was a problem hiding this comment.
removed some redundant steps as we already have a clean solution.
Also copy changes from MCT azure-pipeline: https://github.com/CommunityToolkit/Maui/pull/283/files
jfversluis
approved these changes
May 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Issues Fixed
Behavioral Changes
PR Checklist
approved