This repository was archived by the owner on Dec 12, 2024. It is now read-only.
fix issues marshaling booleans #823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotnet land, bools aren't blittable and every
[UnmanagedCallersOnly]
method that took a bool was failing a runtime check because of the bool - which is weird - you would think that the compiler would catch that as it does with other types, but not in this case.The fix is in two parts:
This fixes 10 tests.