This repository was archived by the owner on Dec 12, 2024. It is now read-only.
add sequential naming tools #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexsoto
approved these changes
Mar 27, 2024
mandel-macaque
suggested changes
Mar 28, 2024
|
|
||
| public string SafeName (string name) | ||
| { | ||
| lock (nameLock) { |
There was a problem hiding this comment.
I believe that Interlocked.Increment will give you the same result, you'll get the lock out and the code will be more performant: https://learn.microsoft.com/en-us/dotnet/api/system.threading.interlocked.increment?view=net-8.0&redirectedfrom=MSDN#System_Threading_Interlocked_Increment_System_Int32__
Comment on lines
8
to
10
| int current; | ||
| string prefix; | ||
| object nameLock = new object (); |
There was a problem hiding this comment.
Suggested change
| int current; | |
| string prefix; | |
| object nameLock = new object (); | |
| int current; | |
| string prefix; |
Comment on lines
20
to
22
| lock (nameLock) { | ||
| return CSSafeNaming.SafeIdentifier ($"{prefix}{name}{current++}"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| lock (nameLock) { | |
| return CSSafeNaming.SafeIdentifier ($"{prefix}{name}{current++}"); | |
| } | |
| return CSSafeNaming.SafeIdentifier ($"{prefix}{name}{Interlocked.Increment(ref current)}"); |
rolfbjarne
approved these changes
Apr 5, 2024
mcumming
approved these changes
Apr 11, 2024
rolfbjarne
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sequential naming