fix memory leaks in pytensor constructor and copy constructor #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, looks like the problem is solved -- thanks! |
|
Are you planning on putting out a 0.19.1 release for this? I think this is a pretty serious issue -- my jobs were leaking tens of gigabytes per hour and couldn't run to completion, and I spent over a day narrowing down the issue, thinking the whole time I was using shared_ptr wrong or something. |
|
Thanks for the reminder, you're right we should have made a release a week ago -- will do it now! |
|
Release is out on conda-forge! BTW if you ever have quick questions or remarks, we also try to be very active on our gitter channel: gitter.im/QuantStack/Lobby would be cool to hear what you're doing with xtensor :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #156 (the leak was in the copy constructor of pytensor, it's fine with std::move into the tuple).
Thanks for the great bug report @daniel-ziegler – would be cool if you could confirm that this solves your issue.