Skip to content

Conversation

PerretB
Copy link
Contributor

@PerretB PerretB commented May 8, 2019

This fixes undefined symbol issues when building on the manylinux1 docker image (with gcc 7.2).

@SylvainCorlay
Copy link
Member

Thanks for the PR. In xtensor core we have been maintaining a list of compiler workarounds. It may be interesting to do the same with xtensor-python if we have specific workarounds here.

@PerretB
Copy link
Contributor Author

PerretB commented May 8, 2019

I can add a "Compiler Workarounds" page in the "Developer zone" of the doc. However, I am not quite sure of the range of affected compiler. @JohanMabille suggested me this patch in gitter when I described the problem and he told that it had already experienced something similar with xtensor-r. Johan do you have a more precise idea on affected compilers ?

@JohanMabille
Copy link
Member

@SylvainCorlay correct me if I'm wrong, but this affects all the tested versions of gcc (from 4.9 up to 7.2). We haven't tested with gcc 8 and gcc 9. Let's say all versions are affected for now, we can refine later. Clang and MSVC are not affected.

@SylvainCorlay
Copy link
Member

Yep, maybe worth mentioning GCC without specifying a version then.

@JohanMabille JohanMabille merged commit 9e57798 into xtensor-stack:master May 9, 2019
@SylvainCorlay
Copy link
Member

Thanks @PerretB !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants