Skip to content

Fixing constructor bug pytensor<..., 0> #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2021
Merged

Fixing constructor bug pytensor<..., 0> #263

merged 2 commits into from
May 31, 2021

Conversation

tdegeus
Copy link
Member

@tdegeus tdegeus commented May 28, 2021 •
edited
Loading

Fix of the following:

I am using a library that uses 'xscalar'. Now I'm wrapping with xtensor-python and am getting on Windows only:

pytensor.hpp(436,18): error C2466: cannot allocate an array of constant size 0
...
message : see reference to function template instantiation 'xt::pytensor<double,0,xt::layout_type::dynamic> xt::pytensor<double,0,xt::layout_type::dynamic>::from_shape<std::array<size_t,0>>(S &&)' being compiled with
[
    S=std::array<size_t,0>
]

Ref: tdegeus/GMatTensor#29

@tdegeus tdegeus mentioned this pull request May 30, 2021
Closed
JohanMabille
JohanMabille requested changes May 31, 2021
View reviewed changes
@JohanMabille JohanMabille merged commit 2a68837 into xtensor-stack:master May 31, 2021
@tdegeus tdegeus deleted the scalar branch May 31, 2021 09:45
@tdegeus tdegeus mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdegeus @JohanMabille