Skip to content

Improve adding custom action to buttons. #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2019
Merged

Improve adding custom action to buttons. #114

merged 2 commits into from
Nov 11, 2019

Conversation

om3rcitak
Copy link
Contributor

Improve adding custom action to buttons.

For example I want add a button with custom action but this package not supported that. After this pull request, everybody can button with custom action using via like following code:

File: app/Datatables/UsersDataTable.php

...
public function html()
    {
        return $this->builder()
            ->setTableId('usersdatatable-table')
            ->columns($this->getColumns())
            ->minifiedAjax()
            ->dom('Bfrtip')
            ->orderBy(0)
            ->buttons(
                (new Button)->text('Button Test')->action('alert("clicked!")')
            );
    }
...

Btw, I supported before this PR codes. So this PR not broke older codes.

yajra
yajra requested changes Nov 8, 2019
View reviewed changes
@yajra yajra changed the title improve adding custom action to buttons Improve adding custom action to buttons. Nov 11, 2019
@yajra yajra merged commit 10c6798 into yajra:4.0 Nov 11, 2019
@yajra
Copy link
Owner

yajra commented Nov 11, 2019

Released on v4.20.0 🚀

@matteocostantini
Copy link
Contributor

Hi, i have install 4.20 in 7.0.33 php environment (it's need...) but
(1/1) FatalThrowableErrorCall to undefined function Yajra\DataTables\Html\substring()

Can you help me?

@om3rcitak om3rcitak mentioned this pull request Nov 11, 2019
Merged
@om3rcitak
Copy link
Contributor Author

om3rcitak commented Nov 11, 2019 •
edited
Loading

@matteocostantini I send PR for your problem. Details: #116

@yajra This PR should be published immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajra yajra yajra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@om3rcitak @yajra @matteocostantini