Skip to content

HTML title for columns labels #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2020
Merged

HTML title for columns labels #125

merged 4 commits into from
Apr 17, 2020

Conversation

mgralikowski
Copy link
Contributor

A simple update to allow set custom HTML title instead auto-generated from "title".

Usage:
Column::computed('image')->title('')->htmlTitle('User image thumb');

@mgralikowski
Update Column.php
eb448ac 
Add new custom attribute.
@mgralikowski
Update HasTable.php
4d6e2e3 
Override HTML title if it exists.
@mgralikowski
Copy link
Contributor Author

mgralikowski commented Apr 13, 2020 •
edited
Loading

A good use case is to use a title to reorder column plugin .

Button::make('colvis')
->text('Columns')
->columnText("function (dt, idx) { return $(dt.column(idx).header()).prop('title'); }")

@mgralikowski
Copy link
Contributor Author

Instead html-title we can use titleAttr like datatables do. What do You think?

@yajra
Copy link
Owner

yajra commented Apr 14, 2020

Can you please link some ref where titleAttr is being used? The PR looks good though.

@mgralikowski
Copy link
Contributor Author

In buttons: https://datatables.net/reference/option/buttons.buttons.titleAttr

@yajra
Copy link
Owner

yajra commented Apr 14, 2020

I see, I think titleAttr would be a good one to use for consistency with the js library. Thanks!

@mgralikowski
Update Column.php
8f7b2e5 
Change a naming convention.
@mgralikowski
Update HasTable.php
3a32893 
Change a naming convention.
mgralikowski
mgralikowski commented Apr 15, 2020
View reviewed changes
Copy link
Contributor Author

@mgralikowski mgralikowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change a naming convention.

@yajra yajra merged commit 8fbc2ad into yajra:4.0 Apr 17, 2020
@yajra
Copy link
Owner

yajra commented Apr 17, 2020

Released on v4.25.0 🚀 Thanks!

yajra added a commit that referenced this pull request Apr 17, 2020
@yajra
Fix PR #125.
7d3d914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgralikowski @yajra