Skip to content

Fix: app auth token expiration edge case #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix: app auth token expiration edge case #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bugfix: subtract timedelta of one minute from app auth flows
  • Loading branch information
@mchieco
mchieco committed Jun 9, 2025
commit d76d1ffab788035e488ff1e48c94e4531fa00f08
20 changes: 14 additions & 6 deletions githubkit/auth/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,13 @@ def sync_auth_flow(
response.read()
response = self._parse_installation_auth_response(response)
token = response.parsed_data.token
expire = datetime.strptime(
response.parsed_data.expires_at, "%Y-%m-%dT%H:%M:%SZ"
).replace(tzinfo=timezone.utc) - datetime.now(timezone.utc)
expire = (
datetime.strptime(
response.parsed_data.expires_at, "%Y-%m-%dT%H:%M:%SZ"
).replace(tzinfo=timezone.utc)
- datetime.now(timezone.utc)
- timedelta(minutes=1)
)
cache.set(key, token, expire)
request.headers["Authorization"] = f"token {token}"
yield request
Expand Down Expand Up @@ -250,9 +254,13 @@ async def async_auth_flow(
await response.aread()
response = self._parse_installation_auth_response(response)
token = response.parsed_data.token
expire = datetime.strptime(
response.parsed_data.expires_at, "%Y-%m-%dT%H:%M:%SZ"
).replace(tzinfo=timezone.utc) - datetime.now(timezone.utc)
expire = (
datetime.strptime(
response.parsed_data.expires_at, "%Y-%m-%dT%H:%M:%SZ"
).replace(tzinfo=timezone.utc)
- datetime.now(timezone.utc)
- timedelta(minutes=1)
)
await cache.aset(key, token, expire)
request.headers["Authorization"] = f"token {token}"
yield request
Expand Down