Skip to content

Fix: remove verified_at from verification schema required fields #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Fix: remove verified_at from verification schema required fields #229

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01754f1
fix: remove verified_at from verification schema required fields
aitestino Jun 29, 2025
6854f43
Apply suggestions from code review
yanyongyu Jun 30, 2025
6d2ac9e
Update pyproject.toml
yanyongyu Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,11 @@ source = "https://raw.githubusercontent.com/github/rest-api-description/main/des
# git user date format should be date-time
"/components/schemas/git-user/properties/date" = { format = "date-time" }

# https://github.com/yanyongyu/githubkit/pull/229
# https://github.com/github/rest-api-description/issues/4995
# verified_at should be optional when commit not verified
"/components/schemas/verification/required" = { "<remove>" = ["verified_at"] }

# https://github.com/yanyongyu/githubkit/pull/134
# blob_url and raw_url may be null when the diff file is submodule's file
"/components/schemas/diff-entry/properties/blob_url" = { type = [
Expand Down