Skip to content

Fix 32-bit MSVC compiler error due to unknown command #warning #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix 32-bit MSVC compiler error due to unknown command #warning #2202

wants to merge 1 commit into from
+5 −7

Conversation

thbeu
Copy link
Contributor

@thbeu thbeu commented Aug 8, 2025 •
edited
Loading

Resolves #2201

@thbeu thbeu changed the title #2201 Fix 32-bit MSVC compiler error due to unknown command #warning Fix 32-bit MSVC compiler error due to unknown command #warning Aug 8, 2025
yhirose
yhirose reviewed Aug 8, 2025
View reviewed changes
@yhirose
Copy link
Owner

yhirose commented Aug 10, 2025 •
edited
Loading

@thbeu how about this? It's simpler and no code duplication.

/*
 * Platform compatibility check
 */

#if defined(_WIN32) && !defined(_WIN64)
#if defined(_MSC_VER)
#pragma message(                                                               \
    "cpp-httplib doesn't support 32-bit Windows. Please use a 64-bit compiler.")
#else
#warning                                                                       \
    "cpp-httplib doesn't support 32-bit Windows. Please use a 64-bit compiler."
#endif
#elif defined(__SIZEOF_POINTER__) && __SIZEOF_POINTER__ < 8
#warning                                                                       \
    "cpp-httplib doesn't support 32-bit platforms. Please use a 64-bit compiler."
#elif defined(__SIZEOF_SIZE_T__) && __SIZEOF_SIZE_T__ < 8
#warning                                                                       \
    "cpp-httplib doesn't support platforms where size_t is less than 64 bits."
#endif

@yhirose
Copy link
Owner

yhirose commented Aug 11, 2025

Could you please show me what error you get when you run my suggested code with v0.25.0 MSVC on your machine?

@thbeu
Copy link
Contributor Author

thbeu commented Aug 12, 2025

Could you please show me what error you get when you run my suggested code with v0.25.0 MSVC on your machine?

Builds as expected (with one warning C4244 though).

MSBuild-Version 17.14.18+a338add32 für .NET Framework

  1>Checking Build System
  Building Custom Rule C:/Users/thbeu/source/repos/cpp-httplib/CMakeLists.txt
  httplib.cc
  cpp-httplib doesn't support 32-bit Windows. Please use a 64-bit compiler.
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244: "Initialisierung": Konvertierung von "_Ty" in "_Ty1", möglicher Datenverlust [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:         with [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:         [ [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:             _Ty=__int64 [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:         ] [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:         and [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:         [ [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:             _Ty1=size_t [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16): warning C4244:         ] [C:\Users\thbeu\source\repos\cpp-httplib\build2\httplib.vcxproj]
  (Quelldatei „out/httplib.cc“ wird kompiliert)
      C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\utility(303,16):
      der Vorlageninstanziierungskontext (der älteste zuerst) ist
          C:\Users\thbeu\source\repos\cpp-httplib\build2\out\httplib.cc(3292,24):
          Siehe Verweis auf die gerade kompilierte Instanziierung "std::pair<size_t,size_t>::pair<__int64,unsigned int,0>(std::pair<__int64,unsigned int> &&) noexcept" der Funktions-Vorlage.
              C:\Users\thbeu\source\repos\cpp-httplib\build2\out\httplib.cc(3292,3):
              Ersten Verweis auf "std::pair<size_t,size_t>::pair" in "httplib::detail::get_range_offset_and_length" anzeigen
  
  httplib.vcxproj -> C:\Users\thbeu\source\repos\cpp-httplib\build2\Debug\cpp-httplib.lib
  Building Custom Rule C:/Users/thbeu/source/repos/cpp-httplib/CMakeLists.txt

I updated PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhirose yhirose yhirose left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSVC: Invalid preprocessor command 'warning'
2 participants
@thbeu @yhirose