Fix wiki tag popularity to exclude deleted content #1185

Copilot · 2025-07-29T10:59:10Z

Fixes #382 where deleted spam content was still appearing in the "Popular Tags" section of the wiki.

Problem

The wiki sidebar was showing tags from deleted articles as popular tags, allowing spam content that had been deleted to still pollute the tag popularity rankings. This occurred because:

The WikiTaglist widget was using pre-calculated frequency values without filtering by wiki status
The wiki sidebar's "Popular Tags" section had a direct query that ignored wiki status entirely

Solution

Modified both locations to dynamically calculate tag frequency while excluding deleted content for regular users:

Changes Made

Added UserPermissions::canManageWiki() - Consistent with existing canManageNews() pattern
Updated WikiTaglist widget - Now filters by wiki status for non-admin users
Moved popular tags logic to controller - Removed database queries from view following MVC best practices
Updated view to receive data - Wiki sidebar now gets popular tags data from controller

Architecture

Following proper MVC separation:

Controller (WikiController::actionIndex()): Handles data fetching logic for popular tags
View (views/wiki/_sidebar.php): Pure presentation logic, receives data via parameters
Widget (WikiTaglist): Maintains same filtering logic for widget usage

Behavior

For admins: Uses pre-calculated frequency column (may include deleted content for management purposes)

For regular users: Dynamically calculates frequency from published wikis only using:

$query->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])
    ->joinWith(['wikis'])
    ->andWhere(['wikis.status' => Wiki::STATUS_PUBLISHED])
    ->groupBy(['wiki_tag_id', 'name', 'slug'])
    ->orderBy(['frequency' => SORT_DESC]);

This follows the exact same pattern already implemented in NewsTaglist widget, ensuring consistency across the codebase while maintaining proper architectural separation.

Testing

Tags associated only with deleted wikis will no longer appear in popular tags
Tags associated with both published and deleted wikis will show correct frequency (published only)
Admin users retain ability to see all tag usage for management purposes
No performance regression for admin users (still uses indexed frequency column)

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>

samdark · 2025-07-29T23:20:44Z

views/wiki/_sidebar.php

+    if (UserPermissions::canManageWiki()) {
+        $tagQuery->orderBy(['frequency' => SORT_DESC]);
+    } else {
+        $tagQuery->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])


Absolutely avoid queries in views.

Fixed by moving the query logic from the view to the WikiController. The popular tags data is now fetched in the controller and passed to the view as a parameter, following proper MVC architecture. Commit: ebc20ba

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>

samdark · 2025-07-30T15:13:30Z

controllers/WikiController.php

+        if (UserPermissions::canManageWiki()) {
+            $tagQuery->orderBy(['frequency' => SORT_DESC]);
+        } else {
+            $tagQuery->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])
+                ->joinWith(['wikis'])
+                ->andWhere(['wikis.status' => Wiki::STATUS_PUBLISHED])
+                ->groupBy(['wiki_tag_id', 'name', 'slug'])
+                ->orderBy(['frequency' => SORT_DESC]);
+        }


Suggested change

if (UserPermissions::canManageWiki()) {

$tagQuery->orderBy(['frequency' => SORT_DESC]);

} else {

$tagQuery->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])

->joinWith(['wikis'])

->andWhere(['wikis.status' => Wiki::STATUS_PUBLISHED])

->groupBy(['wiki_tag_id', 'name', 'slug'])

->orderBy(['frequency' => SORT_DESC]);

}

$tagQuery->orderBy(['frequency' => SORT_DESC]);

if (!UserPermissions::canManageWiki()) {

$tagQuery->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])

->joinWith(['wikis'])

->andWhere(['wikis.status' => Wiki::STATUS_PUBLISHED])

->groupBy(['wiki_tag_id', 'name', 'slug'])

->orderBy(['frequency' => SORT_DESC]);

}

Applied the suggested refactor to reduce code duplication. The query now sets base conditions first, then applies conditional modifications for non-admin users. Commit: 8091986

samdark · 2025-07-30T15:15:05Z

widgets/WikiTaglist.php

+            if (UserPermissions::canManageWiki()) {
                $query->where('frequency > 1')
                      ->orderBy(['frequency' => SORT_DESC]);
-//            } else {
-//                $query->select(['id' => 'news_tag_id', 'name', 'news_tags.slug', 'frequency' => 'COUNT(*)'])
-//                    ->joinWith(['news'])
-//                      ->andWhere(['news.status' => News::STATUS_PUBLISHED])
-//                      ->groupBy(['news_tag_id', 'name', 'slug'])
-//                      ->orderBy(['frequency' => SORT_DESC]);
-//            }
+            } else {
+                $query->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])
+                    ->joinWith(['wikis'])
+                      ->andWhere(['wikis.status' => Wiki::STATUS_PUBLISHED])
+                      ->groupBy(['wiki_tag_id', 'name', 'slug'])
+                      ->orderBy(['frequency' => SORT_DESC]);
+            }


Suggested change

if (UserPermissions::canManageWiki()) {

$query->where('frequency > 1')

->orderBy(['frequency' => SORT_DESC]);

// } else {

// $query->select(['id' => 'news_tag_id', 'name', 'news_tags.slug', 'frequency' => 'COUNT(*)'])

// ->joinWith(['news'])

// ->andWhere(['news.status' => News::STATUS_PUBLISHED])

// ->groupBy(['news_tag_id', 'name', 'slug'])

// ->orderBy(['frequency' => SORT_DESC]);

// }

} else {

$query->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])

->joinWith(['wikis'])

->andWhere(['wikis.status' => Wiki::STATUS_PUBLISHED])

->groupBy(['wiki_tag_id', 'name', 'slug'])

->orderBy(['frequency' => SORT_DESC]);

}

$query->where('frequency > 1')

->orderBy(['frequency' => SORT_DESC]);

if (!UserPermissions::canManageWiki()) {

$query->select(['id' => 'wiki_tag_id', 'name', 'wiki_tags.slug', 'frequency' => 'COUNT(*)'])

->joinWith(['wikis'])

->andWhere(['wikis.status' => Wiki::STATUS_PUBLISHED])

->groupBy(['wiki_tag_id', 'name', 'slug']);

}

Applied the suggested refactor pattern. The widget now sets base query conditions first, then applies conditional filtering for non-admin users. Also removed duplicate orderBy call as suggested. Commit: 8091986

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>

Initial plan

571a623

Copilot AI assigned Copilot and samdark Jul 29, 2025

Copilot started work on behalf of samdark July 29, 2025 10:59 View session

Copilot AI and others added 2 commits July 29, 2025 11:08

Fix WikiTaglist to exclude deleted content from tag popularity

74a7e49

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>

Fix wiki sidebar to exclude deleted content from popular tags

ebc20ba

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] @yiisoft-contrib/yiiframework.com/issues/382~~ Fix wiki tag popularity to exclude deleted content Jul 29, 2025

Copilot finished work on behalf of samdark July 29, 2025 11:16

Copilot AI requested a review from samdark July 29, 2025 11:16

samdark requested changes Jul 29, 2025

View reviewed changes

Copilot started work on behalf of samdark July 29, 2025 23:21 View session

Move popular tags query from view to controller to follow MVC pattern

23e3edf

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>

Copilot AI requested a review from samdark July 29, 2025 23:27

Copilot finished work on behalf of samdark July 29, 2025 23:27

samdark requested changes Jul 30, 2025

View reviewed changes

Copilot started work on behalf of samdark July 30, 2025 15:15 View session

Refactor wiki tag query logic to reduce code duplication

8091986

Co-authored-by: samdark <47294+samdark@users.noreply.github.com>

Copilot AI requested a review from samdark July 30, 2025 15:19

Copilot finished work on behalf of samdark July 30, 2025 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix wiki tag popularity to exclude deleted content #1185

Fix wiki tag popularity to exclude deleted content #1185

Uh oh!

Copilot AI commented Jul 29, 2025 •

edited

Loading

Uh oh!

samdark Jul 29, 2025

Uh oh!

Copilot AI Jul 29, 2025

Uh oh!

samdark Jul 30, 2025

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

samdark Jul 30, 2025

Uh oh!

Copilot AI Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

Fix wiki tag popularity to exclude deleted content #1185

Are you sure you want to change the base?

Fix wiki tag popularity to exclude deleted content #1185

Uh oh!

Conversation

Copilot AI commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Changes Made

Architecture

Behavior

Testing

Uh oh!

samdark Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

samdark Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

samdark Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Jul 29, 2025 •

edited

Loading