Skip to content

Make sure the statefulset that is deleted manually gets re-created. #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2017

Conversation

alexeyklyukin
Copy link
Contributor

Per report and analysis by Manuel Gomez.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 11.208% when pulling 439613c on fix-sync-non-existing-statefulset into 6c57334 on master.

create{Object} for services, endpoints and PDBs refused to continue if
there is a cached definition in the cluster, however, the only place
where it makes sense is when creating a new cluster. Note that contrary
to the statefulset this doesn't fix any issues, since those definitions
were nullified correspondingly when the sync code detected there is no
object present in the Kubernetes cluster.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 11.21% when pulling 0d463af on fix-sync-non-existing-statefulset into 6c57334 on master.

@mgomezch
Copy link
Contributor

👍

1 similar comment
@alexeyklyukin
Copy link
Contributor Author

👍

@alexeyklyukin alexeyklyukin merged commit da0de8c into master Dec 21, 2017
@mgomezch mgomezch deleted the fix-sync-non-existing-statefulset branch December 21, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants