Skip to content

return error when Kube API is down during statefulset sync #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

return error when Kube API is down during statefulset sync #2064

merged 1 commit into from
Oct 18, 2022

Conversation

machine424
Copy link
Contributor

@machine424 machine424 commented Oct 5, 2022 •
edited by FxKu
Loading

fixes #2031

I think the refactor in #1848 has introduced this regression, do you think it was intended?

Before the refactor, getPodEnvironmentSecretVariables and getPodEnvironmentConfigMapVariables were called directly in generateStatefulSet and we used to return an error (and halt the sync) instead of just logging the error and continue sync with missing data.

Maybe add a test and adjust documentation somewhere.

@machine424
Copy link
Contributor Author

Maybe @FxKu as he took care of the refactor.

@FxKu
Copy link
Member

FxKu commented Oct 13, 2022

@machine424 can you rebase? We merged #2045 which introduced some small changes in the same code parts.

@FxKu FxKu added this to the 1.9 milestone Oct 13, 2022
@machine424 machine424 requested a review from hughcapet as a code owner October 13, 2022 15:17
@machine424
Copy link
Contributor Author

machine424 commented Oct 13, 2022 •
edited
Loading

@FxKu, done.

Don't you think we should also release a 1.8.x fix as it is a regression? We have multiple clusters that restart for nothing (we use etcd as dcs to avoid relying on the Kube API) and we'd like to hotfix them.

FxKu
FxKu reviewed Oct 17, 2022
View reviewed changes
@FxKu FxKu changed the title Fix the Operator rolling update statefulsets unnecessary whien Kube A… return error when Kube API is down during statefulset sync Oct 18, 2022
@FxKu
Copy link
Member

FxKu commented Oct 18, 2022

👍

1 similar comment
@idanovinda
Copy link
Member

👍

@FxKu FxKu merged commit 640581f into zalando:master Oct 18, 2022
@FxKu
Copy link
Member

FxKu commented Oct 18, 2022

Thanks again @machine424. It will be included in the next release (should be there soon). There are too many changes already merged to do another 1.8.x release. In the meantime, you could try to patch 1.8.2 yourself with your fix and use a local image.

@machine424
Copy link
Contributor Author

@FxKu, I see.

If anybody is interested in a 1.8.2 release patched with this fix only, they could try docker pull wiremind/postgres-operator:v1.8.2-640581fb4661dbab852dfc0995b5e9f6140fd8f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FxKu FxKu FxKu left review comments

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

the Operator rolling update statefulsets unnecessary whien Kube API down.
3 participants
@machine424 @FxKu @idanovinda