Interpret KUBERNETES_SERVICE_HOST as hostname if not parsed as IP address #2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ress This allows correctly connecting to the Kubernetes API when the service host is set as a hostname. This is at least the case on gardener.cloud . I'm running the patched version in production. Related to zalando#2047 which describes the same problem I had.
FxKu
reviewed
Apr 13, 2023
| else | ||
| echo "Unrecognized IP format '$KUBERNETES_SERVICE_HOST'" | ||
| echo "KUBERNETES_SERVICE_HOST was not set" | ||
| fi |
There was a problem hiding this comment.
can you align the indentation? If I look at the rest of the file it seems 4 spaces are used more :)
There was a problem hiding this comment.
I'll reindent the entire file, because it's 2, 4 or 6 spaces, and that bothers me now that you mentioned it ;).
FxKu
reviewed
Apr 13, 2023
| if [ "$KUBERNETES_SERVICE_HOST" != "${KUBERNETES_SERVICE_HOST#*[0-9].[0-9]}" ]; then | ||
| echo "IPv4" | ||
| K8S_API_URL=https://$KUBERNETES_SERVICE_HOST:$KUBERNETES_SERVICE_PORT/api/v1 | ||
| elif [ "$KUBERNETES_SERVICE_HOST" != "${KUBERNETES_SERVICE_HOST#*:[0-9a-fA-F]}" ]; then | ||
| echo "IPv6" | ||
| K8S_API_URL=https://[$KUBERNETES_SERVICE_HOST]:$KUBERNETES_SERVICE_PORT/api/v1 | ||
| elif [ -n "$KUBERNETES_SERVICE_HOST" ]; then |
There was a problem hiding this comment.
-n is null check, right? Isn't -z better because it's checks null and not set?
There was a problem hiding this comment.
No, because that arm checks if there is any value in KUBERNETES_SERVICE_HOST, and uses it as a hostname. I wanted to print a message when KUBERNETES_SERVICE_HOST was not set, for instance when someone want to set K8S_API_URL directly.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows correctly connecting to the Kubernetes API when the service host is set as a hostname. This is at least the case on gardener.cloud . I'm running the patched version in production.
Related to #2047 which describes the same problem I had.