Enable specifying PVC retention policy for auto deletion #2343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
reviewed
Jun 22, 2023
|
As we've already discussed in person, you could try to extend the scaling e2e test with checks if PVCs get removed or not |
|
@idanovinda @FxKu this feature needed for us too , when we can expect this to be merged? |
Can I pitch in and get this done, as we need this feature ASAP. |
FxKu
reviewed
Sep 8, 2023
FxKu
reviewed
Sep 8, 2023
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users can specify the number of instances in the manifest, both scaling up and scaling down. It creates the PVCs when there is a scaling up event. However, where there is a scaling down event, the control plane doesn't automatically delete the PVCs created for StatefulSets that are no longer needed. It requires manual checking and deletion to clean up the unused PVCs. As a result, unused PVCs continue to occupy storage resources, leading to potential inefficiencies and unnecessary costs.
Solution
In Kubernetes v1.23, a new feature has been introduced to address the issue of unused PVCs (see docs). The operator should set the retention policy in the Statefulsets of every clusters.
To specify the auto-deletion policy in the configmap, we can set:
while in the CRD configuration:
The default values are
"retain"for"when_deleted"and"when_scaled".