Make PodDisruptionBudget master label selector optional #2364
Conversation
|
Hi, |
|
This is awesome and would help us to use PDBs with Postgres. |
| @@ -219,6 +219,7 @@ type Config struct { | |||
| ReplicaDNSNameFormat StringTemplate `name:"replica_dns_name_format" default:"{cluster}-repl.{namespace}.{hostedzone}"` | |||
| ReplicaLegacyDNSNameFormat StringTemplate `name:"replica_legacy_dns_name_format" default:"{cluster}-repl.{team}.{hostedzone}"` | |||
| PDBNameFormat StringTemplate `name:"pdb_name_format" default:"postgres-{cluster}-pdb"` | |||
| PDBMasterLabelSelector *bool `name:"pdb_master_label_selector" default:"true"` | |||
There was a problem hiding this comment.
In line with the others why not call it enable?
There was a problem hiding this comment.
No good reason, I can rename it to EnablePDBMasterLabelSelector, it's a bit long but it follows the existing convention, wdyt?
|
@FxKu sounds like something useful to many people, tiny comment and then looks like we can tackle it. I think it is important though for readers to understand that with this, you hand of to your infrastructure the responsibility to migrate masters only in healthy situations. |
|
👍 |
1 similar comment
|
👍 |
Fix: #1663
Introduce the
pdb_master_label_selectorconfig that by default is enabled but if disabled will not add thespilo-role: mastermatch label to the cluster PodDisruptionBudget.