Skip to content

chore(build): Add OCI label for container image source #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

sklirg
Copy link
Contributor

@sklirg sklirg commented Feb 15, 2024

As specified in the OpenContainers Annotations Spec: https://specs.opencontainers.org/image-spec/annotations/


Problem description

Automated tooling which checks container registries for new tags might not be able to find release notes (this is often via source code/parsing a CHANGELOG file) since this is not included in the container registry. Adding this annotation will allow tooling to follow the link to the source code, and look for release notes there. The tooling can then include these release notes in e.g. PRs with container image version bumps.

Dependabot and Renovatebot both use this annotation for this purpose:

Linked issues

N/A

Checklist

Please, ensure your contribution matches the following items:

  • Your go code is formatted. Your IDE should do it automatically for you.
  • You have updated generated code when introducing new fields to the acid.zalan.do api package.
  • New configuration options are reflected in CRD validation, helm charts and sample manifests.
  • New functionality is covered by unit and/or e2e tests.
  • You have checked existing open PRs for possible overlay and referenced them.

If this change is accepted I can follow up and add it to some other repositories related to the postgres-operator as well, where I've experienced this to be missing :-)

@sklirg
Copy link
Contributor Author

sklirg commented Feb 28, 2024

@FxKu Sorry to ping you, but I see you're active in this repository. Is this change something you/other maintainers can have a look at when you have time? Is there anything I have to do to have this change considered? 😄

@macedigital
Copy link
Member

Hello @sklirg thank you for your contribution. You're proposal sounds interesting, and from my perspective we could add the label.

@macedigital
Copy link
Member

👍

@FxKu FxKu added this to the 1.11.0 milestone Mar 4, 2024
@FxKu
Copy link
Member

FxKu commented Mar 4, 2024

👍

@FxKu FxKu merged commit 06947ee into zalando:master Mar 4, 2024
@sklirg sklirg deleted the chore/add-oci-source-label branch March 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants